2

Closed

HTML style markups interfere with CSS Templates

description

The 'container.ascx' uses CSS classes but also fixed "style" elements ... This interferes with each other and basically ruined some of the css settings of my custom template.
This approach does not offer any flexibilty and limits the usage of custom templates.
 
For example:
 
<!-- Bottom Row -->
<tr>
    <td class="Gallery_BottomCapLeft" id="celleftBottomLeft" valign="top" align="left" style="height: 19px" >
    </td>
    <td class="Gallery_Bottom" id="celBottum" colspan="3" valign="top" align="center" style="width:100%; height: 19px;" ></td>
    <td class="Gallery_BottomCapRight" id="celBottomRight"  valign="top" align="right" style="height: 19px"></td>
</tr>
 
The class 'Gallery_Bottom' is used but also the height is set to fixed 19px. This will override any setting define in a css file.
 
Ideally all controls should use CSS classes and omit using any fixed style references.
 
I didn't check all controls but seems alot of them have this issue.
Closed Jul 7, 2011 at 1:12 AM by imagemaker
Marked all issues/features/tasks fixed in the now released v 4.04.00 as "Closed".

comments

superpower wrote Sep 16, 2010 at 2:39 PM

fdafafafsaf

imagemaker wrote Oct 25, 2010 at 3:29 AM

Unfortunately this is true with almost all of the controls (particularly custom server controls which emit in-line style attributes or deprecated attributes such as height, width, align) throughout the module. Gallery is built on legacy code from ASP.Net 1.0 days. Rather than trying to track down all the occurances of in-line styles and confusing css class references, it is the team's plan to scrap all existing Gallery code for a version 5.x that will be built from the ground up using current best practices. It is also quite likely that Gallery 5.x will make use of client side technology such as but not limited to Silverlight 4 for its presentation layer.

imagemaker wrote Apr 7, 2011 at 4:22 AM

All user views (initial gallery container with thumbnails, viewer, slideshow, media player, flash player) and a few administrative controls (configuration) should meet xhtml compliancy requirements in v 4.04.00 with the elimination of element attributes and in-line styles (except where necessary to specify width and height based on configuration specified thumbnail and picture sizes). The CSS style sheets have been greatly reworked and additional rules added to allow more flexibility in customizing gallery appearance via CSS alone. Unfortunately, if one has extensively styled an existing gallery module via css, those existing stylesheets will not in general produce the desired results and will have to be extensively re-worked following upgrade of gallery to v 4.04.00.

imagemaker wrote Apr 14, 2011 at 1:51 AM

All user views and administrative controls have now been made xhtml compliant with no in-line styles nor deprecated html tag attributes with the exception of a very few cases where the application of an in-line style for width or height was necessary for the thumbnail or fixed picture size specified in the Gallery configuration.